Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Play All" button with "Enqeue Method" drop-down menu #5741

Open
3 tasks done
SameenAhnaf opened this issue Mar 3, 2021 · 11 comments
Open
3 tasks done

Replace "Play All" button with "Enqeue Method" drop-down menu #5741

SameenAhnaf opened this issue Mar 3, 2021 · 11 comments
Labels
feature request Issue is related to a feature in the app feed Issue is related to the feed

Comments

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Mar 3, 2021

Checklist

Describe the feature you want

"Play all" button only lets user to play all videos from the beginning. Sometimes, we play another video from the playlist. Still, we need to enqueue the whole or certain videos of the playlist. Following enqeue methods can be added to solve this issue.

  1. All: All videos will be enqeued. The position of the selected videos won't be changed in new enqueued list. But the first video will be the selected video. If shuffled, all videos will be shuffled. But it will let the user choose the first video. Plus, it will let the user browse the playlist just like the original playlist. If no shuffle is selected, the playlist will stream the next video after watching the first selected video. Just like how it works for playlists on YouTube playlists.
  2. None: No video will be enqeued from the channel or playlist. However, enabling "Auto-queue for a related stream" should let the user auto-queue a related stream. Not next video from the channel or playlist.
  3. Only next videos: Only videos arranged after the selected video will be enqeued.
  4. Only previous videos: Only videos arranged before the selected video wiill be enqeued (in a reversed order of the original playlist).
  5. Continue to next videos: All videos will be enqeued with a slight variation. Suppose, a playlist has five videos: A, B, C, D, E. If C video is selected, 1st video will be C, 2nd will be D, 3rd be E, 4th be A and 5th be B and 5th be B.
  6. Continue to previous videos: All videos will be enqeued with a slight variation. Suppose, a playlist has five videos: A, B, C, D, E. If C video is selected, 1st video will be C, 2nd will be B, 3rd will be A, 4th will be E and 5th will be D.

Is your feature request related to a problem? Please describe it

Additional context

How will you/everyone benefit from this feature?

It will let us enqeue only a selected number of videos as we wish. Sometimes, we want to finish watching a playlist part by part. This option will let us fo that.

@daylightEX
Copy link

I would love to see this, too. I was really surprised that you can't just pick a video in, say, the middle of a playlist and have it just queue the following videos automatically.

@SameenAhnaf

This comment was marked as off-topic.

@litetex
Copy link
Member

litetex commented Feb 26, 2022

@SameenAhnaf
The following issues are in my opinion standalone as they are open for different topics:

@sudocanttype
Copy link

Okay I've changed to UI to have the "Enqueue" button and I now have a popup that allows selection of the method.
image
image
However, I am having a lot of trouble integrating the selection of videos for 3,4,5,6. I have no idea what 2 does.
@SameenAhnaf is this generally what you had in mind, though?

@SameenAhnaf
Copy link
Collaborator Author

SameenAhnaf commented Mar 15, 2022

I"m extremely sorry for vague description. Actually, these options work on the basis of selecting a video at first.

  1. All: Selected video will be on top. Other videos will maintain chronology as in the channel or playlist.
  2. None: Select only selected video. Other videos from the playlist will be ignored.
  3. Only next videos: Only that and its next videos from that will point will be queued.
  4. Only previous videos: Only that and previous videos from that point will be queued in a reversed way.
  5. Continue to next videos: All videos will be enqeued with a slight variation. Suppose, a playlist has five videos: A, B, C, D, E. If C video is selected, 1st video will be C, 2nd will be D, 3rd be E, 4th be A and 5th be B and 5th be B.
  6. Continue to previous videos: All videos will be enqeued with a slight variation. Suppose, a playlist has five videos: A, B, C, D, E. If C video is selected, 1st video will be C, 2nd will be B, 3rd will be A, 4th will be E and 5th will be D.
  7. Shuffle: Shuffle all videos right in the feed. Note that reopening that channel or playlist will show videos in a new random order.

Also, these options will be remembered separately for each channel and playlist. By default, None and Allwill be option for unopened channel and playlist. However, default option for unopened channel or playlist will change according to last played channel or playlist respectively.

@sudocanttype
Copy link

sudocanttype commented Mar 15, 2022

I see. I was going too quit on this issue because I had no idea how to integrate the a new list for the selection of the video, but instead I can just add it to the LongClick menu.
image
Does that work for you?

@sudocanttype

This comment was marked as resolved.

@SameenAhnaf
Copy link
Collaborator Author

I don't think, it should be integrated into long click menu. Introducing 7 new options into the same menu would be an overkill. It already has a long list of options. Moreover, this state will be remembered for each channel and playlist separately. So, this info is not directly to the selected video only.

Also, these options will be remembered separately for each channel and playlist. By default, None and Allwill be option for unopened channel and playlist. However, default option for unopened channel or playlist will change according to last played channel or playlist respectively.

@ghost

This comment was marked as spam.

@GameKyuubi
Copy link

Might be good to break this down into two checkpoints: one for the functionality of changing the default behavior to "play playlist starting from selection" instead of "play single item", and one for the kinds of variations in the menu. The first one is expected behavior and it's jarring when it doesn't behave that way. Even after years of using the app I still find myself accidentally loading single songs instead of loading the playlist, which is what I want 95% of the time. The other features are not something I've seen in other apps, so I feel it has a different urgency level. It also has more unknown complexity with how it might affect the usability of the menu, whereas implementation of the first feature seems pretty clear. So I think it's worth splitting these apart.

@larson9999
Copy link

Yesterday I asked the developers of Grayjay to implement 'play from here' as I want it. Today a rough but serviceable version has been deployed.

It's not perfect, but I fully expect it to improve pretty rapidly.

Anyway, if this is functionality you really want and being an early adopter for responsive developers doesn't put you off, might be worth a few minutes checking out Grayjay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app feed Issue is related to the feed
Projects
None yet
Development

No branches or pull requests

6 participants