Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea] Context menu reworking with icons for cleaner experience #5011

Closed
3 tasks done
Lurux opened this issue Nov 26, 2020 · 4 comments
Closed
3 tasks done

[Idea] Context menu reworking with icons for cleaner experience #5011

Lurux opened this issue Nov 26, 2020 · 4 comments
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion

Comments

@Lurux
Copy link

Lurux commented Nov 26, 2020

Checklist

Describe the feature you want

There has been quite a bit of conversation recently about Newpipe's context menus being "too cluttered" and "unintuitive", notably leading to heated conversations around the "start playing from here" feature (see #4805).

Reading the conversations, I decided to take inspiration from #2583 and do my own take on Newpipe's context menus.

Basically, the idea is to have the most common actions displayed as icons in the context menu. The contextual (or "more confusing") options would be out of the view by default, just a scroll away from being accessible:

newpipe idea

In this context, the "add to playlist" icon could be replaced with an "enqueue" option to enqueue that single video. Long pressing the icons would be used to replace the queue with the content of the current page, playing it from the currently selected video (solves #4805).

Is your feature request related to a problem? Please describe it

This would allow to make the menu simpler for newcomers and more consistent, without compromising more advanced options like in the controverted #2368 (no offence). Since the menu would always have the same size and position, this would allow to use muscle memory for the most used actions. Finally, this would allow to play videos without having to wait for the video details to load in the classic "show details" view (which also used to stop the background player, I don't know if that's still the case).

Additional context

This was inspired by #2583 to try and solve the current problems around Newpipe's context menu.

How will you/everyone benefit from this feature?

This feature will help us colonize the galaxy !

In all seriousness, I think this would make Newpipe nicer to look at and simpler for newcomers, while solving quite a few problems as stated above.

@Lurux Lurux added the feature request Issue is related to a feature in the app label Nov 26, 2020
@Lurux Lurux changed the title [Idea] Context menu reworking for simpler and decluttered experience [Idea] Context menu reworking with icons for simpler experience without removing advanced options Nov 26, 2020
@Lurux
Copy link
Author

Lurux commented Nov 27, 2020

You know what, I'll just ping @Stypox so we get a conversation going. He's the author of two of the issues I mentioned here, hopefully he'll be interested 😃

@Lurux Lurux changed the title [Idea] Context menu reworking with icons for simpler experience without removing advanced options [Idea] Context menu reworking with icons for cleaner experience [Feedback needed] Dec 2, 2020
@Stypox
Copy link
Member

Stypox commented Jan 15, 2021

@Lurux sorry for getting in touch so late. I missed this when you first posted a while ago. I really like your solution! If you are going to implement this you can probably take some of my code from #3936

Long pressing the icons would be used to replace the queue with the content of the current page, playing it from the currently selected video

I don't think this is a good idea, as long pressing means something different everywhere else in the app

(no offence)

Now I won't talk to you anymore (just joking, you are right) ;-)

@TobiGr TobiGr added the GUI Issue is related to the graphical user interface label Jan 15, 2021
@Lurux
Copy link
Author

Lurux commented Jan 16, 2021

@Lurux sorry for getting in touch so late. I missed this when you first posted a while ago. I really like your solution! If you are going to implement this you can probably take some of my code from #3936

Eh, unfortunately I don't know anything about Android programming yet... 😕
I do plan on learning more about it at some point, though...

Long pressing the icons would be used to replace the queue with the content of the current page, playing it from the currently selected video

I don't think this is a good idea, as long pressing means something different everywhere else in the app

Yeah, I guess I meant the contrary: simple click replaces the queue, long click extends it; like everywhere else in the app 😄

@Lurux Lurux changed the title [Idea] Context menu reworking with icons for cleaner experience [Feedback needed] [Idea] Context menu reworking with icons for cleaner experience Mar 10, 2021
@SameenAhnaf
Copy link
Collaborator

Closing in favor of #9730

@SameenAhnaf SameenAhnaf added duplicate Issue or discussion is a duplicate of an existing issue or discussion and removed feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion
Projects
None yet
Development

No branches or pull requests

4 participants