Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigation bar (bottom) should be in dark colour even if device has light theme #10412

Open
6 tasks done
milchalpenu opened this issue Sep 13, 2023 · 2 comments
Open
6 tasks done
Labels
discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@milchalpenu
Copy link

milchalpenu commented Sep 13, 2023

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

A lot of dinosaurs like me still use 3-button navigation (Three buttons for Home, Back, and App Overview). In this case the navbar (bottom thing) is coloured with white background. I would recommend this to be changed to either

  • Black
  • Translucent (content behind the buttons)

The system applies a translucent scrim behind the system bars (for API level 29 or higher) or a transparent system bar (for API level 28 or lower). https://developer.android.com/design/ui/mobile/guides/foundations/system-bars

navbar

See attached images for demonstration.

Why do you want this feature?

Looks nicer. (IMHO)

Additional information

No response

@milchalpenu milchalpenu added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Sep 13, 2023
@milchalpenu milchalpenu changed the title navigation bar (bottom) should be in dark theme even if device has light theme navigation bar (bottom) should be in dark colour even if device has light theme Sep 13, 2023
@SameenAhnaf SameenAhnaf added discussion This needs to be discussed before anything is done GUI Issue is related to the graphical user interface and removed needs triage Issue is not yet ready for PR authors to take up labels Sep 13, 2023
@TobiGr
Copy link
Member

TobiGr commented Sep 20, 2023

I am unable to reproduce this. Please provide more info, such as

  • Android version
  • a screenshot from the device settings showing the settings for your navigation bar
  • whether night mode is enabled on your device
  • the theme that is chosen in NewPipe's appearance settings
  • screenshots of NewPipe showing the current behaviour experienced on your device (normal view and with player running)

@TobiGr TobiGr added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Sep 20, 2023
@milchalpenu
Copy link
Author

milchalpenu commented Sep 22, 2023

Thank you for the response.

  • android 11
1 2 3 4 running theme

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

3 participants