Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Video downloading experience from youtube #10378

Closed
6 tasks done
rishab247 opened this issue Aug 25, 2023 · 10 comments · Fixed by #10407
Closed
6 tasks done

Improving Video downloading experience from youtube #10378

rishab247 opened this issue Aug 25, 2023 · 10 comments · Fixed by #10407
Assignees
Labels
downloader Issue is related to the downloader feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@rishab247
Copy link
Contributor

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Video download popup box should be shown as soon as download flow is initiated from youtube app. we should not wait for backend response for metadata and show a loader inside of the pop box.

Why do you want this feature?

Whenever a user tries to download a video from the youtube app through sharing a video to the newPipe app we show a toast "Processing may take some time" then after a few seconds a video download popup is shown. But on slow internet, this gap between toast and popup can increase to 10+ seconds which gives users to impression of an unresponsive device as we are showing an invisible activity that may lead them to exit the download flow.

Additional information

Rough Design mockup
https://github.com/TeamNewPipe/NewPipe/assets/47221639/28f0d4f2-8d0a-4120-bde1-4a83bb57adab

i would love to raise a pr for this. if approved.

@rishab247 rishab247 added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Aug 25, 2023
@opusforlife2
Copy link
Collaborator

Playing devil's advocate: currently, the user can continue interacting with the app until the dialog loads. This popup could block them for a long time.

that may lead them to exit the download flow.

Also, what do you mean by this? How would the flow be exited?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Aug 26, 2023
@rishab247
Copy link
Contributor Author

Currently, users can't interact with YouTube while waiting for the popup to be shown, as we are displaying an invisible activity on top of YouTube while initiating downloads.

Screen_Recording_20230827_010948_YouTube.mp4

There are two ways that a user can exit the download flow:

  1. When a user is trying to scroll, but they see no response from YouTube, they will panic and click on the home button.
  2. When a user is trying to scroll, but they see no response, they keep on trying, which will instantly dismiss the popup before the user can read it (as shown in the above video).

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Aug 26, 2023
@opusforlife2
Copy link
Collaborator

I have no idea what's going on in the video, but I get your point about the invisible activity.

In that case, your solution makes sense.

Please hold off on opening a PR for this right now, though.

@opusforlife2 opusforlife2 added downloader Issue is related to the downloader GUI Issue is related to the graphical user interface and removed needs triage Issue is not yet ready for PR authors to take up labels Aug 26, 2023
@rishab247
Copy link
Contributor Author

Screen_Recording_20230827_020813_NewPipe.mp4

This video should make things clearer. I am using the YouTube mobile app and sharing a video with NewPipe to initiate the download process. Then I see a toast message saying 'Processing may take some time,' which indicates that the download flow has been initiated. However, I haven't seen the popup yet due to the slow internet, which gives the impression that the application is not responsive, even though it is.

Do you want to defer PR for some specific time ?

@opusforlife2
Copy link
Collaborator

Thanks. This video is clear.

We're deferring a lot of stuff to the rewrite. I've asked if your PR can be opened now, or if it should be deferred too. So let's see.

@rishab247
Copy link
Contributor Author

Okay cool

@Stypox
Copy link
Member

Stypox commented Aug 27, 2023

How would you plan to fix this problem? Just showing a loading indicator would be fine imo

@rishab247
Copy link
Contributor Author

yes, i am planing to fix by showing loading indicator on download initiated. i have attached a rough mockup also
https://github.com/TeamNewPipe/NewPipe/assets/47221639/28f0d4f2-8d0a-4120-bde1-4a83bb57adab

@Stypox
Copy link
Member

Stypox commented Aug 27, 2023

Yeah that's a good idea and can be merged before the rewrite, you can proceed, thanks!

@rishab247
Copy link
Contributor Author

rishab247 commented Sep 15, 2023

@Stypox @opusforlife2 @TobiGr please review this PR
#10407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downloader Issue is related to the downloader feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants