-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Video downloading experience from youtube #10378
Comments
Playing devil's advocate: currently, the user can continue interacting with the app until the dialog loads. This popup could block them for a long time.
Also, what do you mean by this? How would the flow be exited? |
Currently, users can't interact with YouTube while waiting for the popup to be shown, as we are displaying an invisible activity on top of YouTube while initiating downloads. Screen_Recording_20230827_010948_YouTube.mp4There are two ways that a user can exit the download flow:
|
I have no idea what's going on in the video, but I get your point about the invisible activity. In that case, your solution makes sense. Please hold off on opening a PR for this right now, though. |
Screen_Recording_20230827_020813_NewPipe.mp4This video should make things clearer. I am using the YouTube mobile app and sharing a video with NewPipe to initiate the download process. Then I see a toast message saying 'Processing may take some time,' which indicates that the download flow has been initiated. However, I haven't seen the popup yet due to the slow internet, which gives the impression that the application is not responsive, even though it is. Do you want to defer PR for some specific time ? |
Thanks. This video is clear. We're deferring a lot of stuff to the rewrite. I've asked if your PR can be opened now, or if it should be deferred too. So let's see. |
Okay cool |
How would you plan to fix this problem? Just showing a loading indicator would be fine imo |
yes, i am planing to fix by showing loading indicator on download initiated. i have attached a rough mockup also |
Yeah that's a good idea and can be merged before the rewrite, you can proceed, thanks! |
@Stypox @opusforlife2 @TobiGr please review this PR |
Checklist
Feature description
Video download popup box should be shown as soon as download flow is initiated from youtube app. we should not wait for backend response for metadata and show a loader inside of the pop box.
Why do you want this feature?
Whenever a user tries to download a video from the youtube app through sharing a video to the newPipe app we show a toast "Processing may take some time" then after a few seconds a video download popup is shown. But on slow internet, this gap between toast and popup can increase to 10+ seconds which gives users to impression of an unresponsive device as we are showing an invisible activity that may lead them to exit the download flow.
Additional information
Rough Design mockup
https://github.com/TeamNewPipe/NewPipe/assets/47221639/28f0d4f2-8d0a-4120-bde1-4a83bb57adab
i would love to raise a pr for this. if approved.
The text was updated successfully, but these errors were encountered: