Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google Material library #10244

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Jul 19, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update Google Material library 1.6.1 -> 1.9.0 (changelog) (as always, release APK bloats by 193 KB, lol)

Things to notice in this update for the rewrite:

  • New Material Search Bar + Search View component: we could probably replace our custom search bar with this. Could save hundreds of lines of code, potentially.
    • Has basically the same features, like the suggestion list and the menu items (like the 'x' for clearing/closing and the hamburger where the filters can be put).
    • I couldn't find anything regarding displaying a "history" for searching, but I don't think this'll be a problem because I think we could just replace the suggestion list dynamically for when the search box is empty. Probably.
    • ✨M a t e r i a l 3✨

There was nothing else of note in the changelogs. (There's also a cool new Carousel component in 1.9.0, but we don't need that for anything.)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AudricV AudricV added the dependency Issues and PRs related to dependencies label Jul 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TobiGr TobiGr merged commit 50fb48f into TeamNewPipe:dev Sep 20, 2023
6 checks passed
This was referenced Oct 5, 2023
@TacoTheDank TacoTheDank deleted the bumpMaterial branch October 23, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Issues and PRs related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants