From 3472e4976738aa23fbbfa9ce7cf411935785d870 Mon Sep 17 00:00:00 2001
From: Siddhesh Naik <siddheshnaik20@protonmail.com>
Date: Sun, 24 Sep 2023 13:36:30 +0530
Subject: [PATCH] Address review comments - opusforlife2

- Updated string value for the dialog option.

Video demo:
- https://github.com/TeamNewPipe/NewPipe/assets/87667048/09962034-146a-4fa6-acbc-5bc58cba2d10

PR Commit Message
Add playlist name and video name in playlist sharing content

- Currently, only a list of videos separated by newline are added in
  the share content.
- This makes it difficult to identify a specific video in a list of
  Urls.
- Used string resources for the sharing content formats.
- Added a confirmation dialog for users to choose between sharing
  playlist formats.
- Added Playlist name as the header and corresponding video name for
  each video url in following format.

Playlist
- Music1: https://media-url1
- Music2: https://media-url2
- Music3: https://media-url3

Screenshots:
| Before | After | Confirmation Dialog |
| --- | --- | --- |
| <img src="https://github.com/TeamNewPipe/NewPipe/assets/87667048/fa7b27b2-91d6-491d-8f93-a8b447263de6" width=270 height=580> | <img src="https://github.com/TeamNewPipe/NewPipe/assets/87667048/e7ddde18-1d3a-4ccb-8c35-f5bf14e48bec" width=270 height=580> | <img src="https://github.com/TeamNewPipe/NewPipe/assets/87667048/c073c41e-8b49-461b-95b2-cab5e7ffb692" width=270 height=580> |

Video demo:
- https://github.com/TeamNewPipe/NewPipe/assets/87667048/09962034-146a-4fa6-acbc-5bc58cba2d10
---
 .../schabi/newpipe/local/playlist/LocalPlaylistFragment.java  | 4 ++--
 app/src/main/res/values/strings.xml                           | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistFragment.java b/app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistFragment.java
index 560ea46545a..79159292bd4 100644
--- a/app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistFragment.java
+++ b/app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistFragment.java
@@ -869,9 +869,9 @@ private void createShareConfirmationDialog() {
 
         new AlertDialog.Builder(getContext())
                 .setTitle(R.string.share_playlist)
-                .setMessage(R.string.share_playlist_with_details_message)
+                .setMessage(R.string.share_playlist_with_titles_message)
                 .setCancelable(true)
-                .setPositiveButton(R.string.share_playlist_with_details, (dialog, which) -> {
+                .setPositiveButton(R.string.share_playlist_with_titles, (dialog, which) -> {
                     sharePlaylist(/* shouldSharePlaylistDetails= */ true);
                 })
                 .setNegativeButton(R.string.share_playlist_with_list, (dialog, which) -> {
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 43a62c53490..dcfb0ec96e9 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -829,8 +829,8 @@
     <string name="image_quality_high">High quality</string>
     <string name="question_mark">\?</string>
     <string name="share_playlist">Share Playlist</string>
-    <string name="share_playlist_with_details_message">Share playlist with details such as playlist name and video titles or as a simple list of video URLs</string>
-    <string name="share_playlist_with_details">Share with details</string>
+    <string name="share_playlist_with_titles_message">Share playlist with details such as playlist name and video titles or as a simple list of video URLs</string>
+    <string name="share_playlist_with_titles">Share with Titles</string>
     <string name="share_playlist_with_list">Share URL list</string>
     <string name="video_details_list_item">- %s: %s</string>
     <string name="share_playlist_content_details">%s\n%s</string>