feature: 푸시알림 #233
Open
feature: 푸시알림 #233
+1,591
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junseo511
approved these changes
Nov 17, 2024
| import kotlinx.coroutines.flow.map | ||
| import javax.inject.Inject | ||
|
|
||
| class DefaultDeviceTokenPreferencesDataSource @Inject constructor( |
There was a problem hiding this comment.
r: 토큰을 통합해서 관리하신다면 이 친구는 분리될 필요가 없을 것 같습니다
| val isMainUiState by viewModel.mainUiState.collectAsState() | ||
| LaunchedEffect(isMainUiState) { | ||
| if (!isMainUiState.characterName.isNullOrBlank() && !isMainUiState.characterChatting.isNullOrBlank()) { | ||
| // |
junseo511
reviewed
Nov 17, 2024
Comment on lines
+232
to
+234
| google-services = { id = "com.google.gms.google-services", version.ref = "googleServices" } | ||
|
|
There was a problem hiding this comment.
c: 위쪽에 Google Play Service라고 이미 있음요 위치 옮겨주심 좋을듯
There was a problem hiding this comment.
이거는 플러그인이고 위에있는건 라이브러리 잖아요..
# Conflicts: # feature/home/src/main/java/com/teamoffroad/feature/home/presentation/HomeScreen.kt # feature/home/src/main/java/com/teamoffroad/feature/home/presentation/HomeViewModel.kt
…roid into feature/219 # Conflicts: # feature/home/build.gradle.kts
…roid into feature/219 # Conflicts: # feature/main/build.gradle.kts # gradle/libs.versions.toml
# Conflicts: # feature/home/src/main/java/com/teamoffroad/feature/home/presentation/HomeScreen.kt # feature/home/src/main/java/com/teamoffroad/feature/home/presentation/component/HomeIcons.kt # feature/home/src/main/res/values/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
Screen_recording_20241117_060357.mp4
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
분기처리가 많이 복잡해서 주석 많이 달아놨습니다. 나중에 지울게요ㅎㅎ
