Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upscaling finishes but doesn't wrap up properly #59

Closed
ToastXJ opened this issue Jan 19, 2025 · 7 comments
Closed

Upscaling finishes but doesn't wrap up properly #59

ToastXJ opened this issue Jan 19, 2025 · 7 comments

Comments

@ToastXJ
Copy link

ToastXJ commented Jan 19, 2025

I am using Windows 11 Pro.

Describe the bug
Exception in thread Thread-3 ():
Traceback (most recent call last):
File "src\ui\QTcustom.py", line 106, in unlink_shared_memory
AttributeError: 'UpdateGUIThread' object has no attribute 'shm'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "threading.py", line 1045, in _bootstrap_inner
File "threading.py", line 982, in run
File "src\ui\ProcessTab.py", line 220, in
File "src\ui\ProcessTab.py", line 296, in renderToPipeThread
File "src\ui\QTcustom.py", line 110, in unlink_shared_memory
TypeError: log() takes 1 positional argument but 2 were given

This is the error msg after processing a video. Finished but doesn't show as finished. Basically halted.

To Reproduce
To upscale a video.

Expected behavior
For the upscaling to wrap up so that the next one in queue can be processed.

Screenshots

Image

Logs
If the application generates a log, please upload it here.

frontend_log.txt
backend_log.txt

Desktop (please complete the following information):

  • OS: Windows 11 Pro

GPU
RTX 4090 tensorrt,

Additional context
Also, under Quality Settings --> Audio Encoder, "copy_audio" option doesn't save, it resets to aac every time I start the UI. It would be nice for it to be saved.

@TNTwise
Copy link
Owner

TNTwise commented Jan 19, 2025

Is this the latest build? I think both bugs are fixed in the latest pre release.

@ToastXJ
Copy link
Author

ToastXJ commented Jan 19, 2025

This is the version I'm on:

prerelease_2.2.0
RVE 2.2.0 pre-release

@TNTwise
Copy link
Owner

TNTwise commented Jan 20, 2025

Try re-downloading the pre release again and see if the issue persists.

@ToastXJ
Copy link
Author

ToastXJ commented Jan 21, 2025

Reinstalling seems to have worked! Thanks for suggesting that.

One thing to note: when I leave the program running with my screen turned off, it throws me this message. I assume that it's perfectly normal, but maybe not the most necessary. Just thought I'd mention it :)

qt.qpa.screen: "Unable to open monitor interface to \\.\DISPLAY1:" "The operation completed successfully."

@ToastXJ
Copy link
Author

ToastXJ commented Jan 21, 2025

I just finished two tasks successfully.

However, when I added another 2 files, started it, got this error message right away, and the frontend closed by itself.

QWidget::repaint: Recursive repaint detected
QBackingStore::endPaint() called with active painter; did you forget to destroy it or call QPainter::end() on it?

I was able to restart the program and upscale the other two videos.

Nothing serious, thought that I'd share it with you.

@TNTwise
Copy link
Owner

TNTwise commented Jan 21, 2025

I just noticed that too in my testing, I will fix before stable.

@ToastXJ
Copy link
Author

ToastXJ commented Jan 21, 2025

Thank you! I have no other issues using it so far.

Again, amazing job building this! Much appreciated!

@ToastXJ ToastXJ closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants