Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize IP Address lookup #7

Open
Canthv0 opened this issue Jul 9, 2019 · 0 comments
Open

Optimize IP Address lookup #7

Canthv0 opened this issue Jul 9, 2019 · 0 comments
Assignees
@Canthv0
Labels
status/backlog In backlog / validated type/feature New feature or request
Milestone
Phase 4: Non Caps...

Comments

@Canthv0
Copy link
Contributor

Canthv0 commented Jul 9, 2019

Currently the IP address lookup code test all IP addresses and then determines if they belong to MSFT according to the MSFT JSON data from https://endpoints.office.com/endpoints/Worldwide?ClientRequestId=

This is resulting in queries being made to the GEO Location endpoint that are not needed. If it is an MSFT Address we don't need to look up the location.

Should look to optimize this further.
@Canthv0 Canthv0 self-assigned this Aug 28, 2019
@Canthv0 Canthv0 added the type/feature New feature or request label Aug 28, 2019
@T0pCyber T0pCyber added the status/backlog In backlog / validated label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Canthv0 Canthv0

Labels
status/backlog In backlog / validated type/feature New feature or request
Projects
None yet
Milestone
Phase 4: Non Capstone Project Feature...
Development

No branches or pull requests
2 participants
@T0pCyber @Canthv0