Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(organigram): redesign #690

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

feat(organigram): redesign #690

wants to merge 20 commits into from

Conversation

friedaxvictoria
Copy link
Contributor

@friedaxvictoria friedaxvictoria commented May 15, 2020 •
edited by DanielHabenicht
Loading

Now the organigram looks and works like the rooms. With the current mock backend everything should be working. However, the mock backend doesn't have any children. I'm currently working on adding children and implementing that into the page.

If you have any suggestions as to how we could name the children, that would be very helpful. At the moment the heading would say Sub-Groups:/Untergruppen:

closes: #660

@friedaxvictoria friedaxvictoria linked an issue May 15, 2020 that may be closed by this pull request
Organigram Redesign #108
Open
@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-690.demo-phonebook.me

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-690.demo-phonebook.me

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-690.demo-phonebook.me

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-690.demo-phonebook.me

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-690.demo-phonebook.me

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-690.demo-phonebook.me

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-690.demo-phonebook.me

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-690.demo-phonebook.me

@DanielHabenicht
Copy link
Collaborator

some remarks:

  • can we make the navigation bar display the org unit name?
    image
  • can we add more depth to the mock data? at least one level?
  • clicking the second level org unit in the navigation tree results in "org unit not found"
  • rename sub group to something consistent with the organization unit naming schema eg Sub-Organization unit or subordinate orgunit
    image
  • clicking the first time on an "extend icon" item in the org unit tree does nothing
  • the tree and org unit node view are not synchronized, if I click an org unit in the node view the tree should automatically extend to the selected org unit

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-690.demo-phonebook.me

@friedaxvictoria
Copy link
Contributor Author

The routing in the container is working. The tree expands on the first click and is also synchronised with the routing in the container.

However, the routing in the tree itself doesn't work yet. The names in the navigation bar are also not yet working.

@friedaxvictoria
Copy link
Contributor Author

The routing for the general overview, nodes, and tree should be working. However, there seems to be an issue with the tests. The one thing that isn't working yet is the names in the navigation bar. Right now it displays the names of every node and the list of displays nodes just gets longer and longer. In addition to that, the routing for the navigation bar also isn't working yet (apart from the Overview and Where Am I? button). One would have to put a UnitTreeNode into the navigateToNextNode(). At the moment it is only getting the node's name.

@mschwrdtnr
Copy link
Member

This can be a Christmas Issue 🎅🏻 🥳 🎉

@mschwrdtnr
Copy link
Member

/azp run T-Systems-MMS.phonebook-preview

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielHabenicht DanielHabenicht Awaiting requested review from DanielHabenicht DanielHabenicht is a code owner

@paule96 paule96 Awaiting requested review from paule96 paule96 is a code owner

@mschwrdtnr mschwrdtnr Awaiting requested review from mschwrdtnr

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
hackthon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organigram malformatted on page reload Organigram Redesign
5 participants
@friedaxvictoria @mmsgithub-ci @DanielHabenicht @mschwrdtnr @paule96