Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly validate git repository URLs everywhere #501

Open
Panaetius opened this issue Nov 1, 2024 · 0 comments
Open

properly validate git repository URLs everywhere #501

Panaetius opened this issue Nov 1, 2024 · 0 comments

Comments

@Panaetius
Copy link
Member

There is a discrepancy in endpoints dealing with repository URLs.

E.g. PATCH on api/data/projects/<project id> allows setting a repository like [email protected]:SwissDataScienceCenter/renku-data-services.git

But then querying api/data/repositories/git%40github.com%3ASwissDataScienceCenter%2Frenku-data-services.git gives a 422 error Sentry issue: RENKU-DATA-SERVICES-1A

We should go over all the places where we use git repository URLs and make sure validation rules are aligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant