From 59ed29d7c6ecf049d1e886c2b5055a6810deba06 Mon Sep 17 00:00:00 2001
From: Ian Bytchek <ianbytchek@gmail.com>
Date: Thu, 4 Jun 2020 17:54:46 +0100
Subject: [PATCH] Improve error naming

---
 .../Observer/Hotkey/Observer.Hotkey.Handler.swift         | 8 ++++----
 source/Observatory/Observer/Hotkey/Observer.Hotkey.swift  | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/source/Observatory/Observer/Hotkey/Observer.Hotkey.Handler.swift b/source/Observatory/Observer/Hotkey/Observer.Hotkey.Handler.swift
index 5d69995..c08a606 100644
--- a/source/Observatory/Observer/Hotkey/Observer.Hotkey.Handler.swift
+++ b/source/Observatory/Observer/Hotkey/Observer.Hotkey.Handler.swift
@@ -86,7 +86,7 @@ extension HotkeyObserver {
                 if Int(status) == eventHotKeyExistsErr {
                     throw Error.hotkeyAlreadyRegistered
                 } else if status != Darwin.noErr {
-                    throw Error.hotkeyRegisterFail(status: status)
+                    throw Error.cannotRegisterHotkey(status: status)
                 }
 
                 self.hotkeyIdentifier = identifier
@@ -95,7 +95,7 @@ extension HotkeyObserver {
 
             private func unregisterEventHotkey() throws {
                 let status: OSStatus = UnregisterEventHotKey(self.hotkeyReference)
-                guard status == Darwin.noErr else { throw Error.hotkeyUnregisterFail(status: status) }
+                guard status == Darwin.noErr else { throw Error.cannotUnregisterHotkey(status: status) }
 
                 self.hotkeyIdentifier = nil
                 self.hotkeyReference = nil
@@ -114,7 +114,7 @@ extension HotkeyObserver.Handler.Definition {
 extension HotkeyObserver.Handler.Definition {
     public enum Error: Swift.Error {
         case hotkeyAlreadyRegistered
-        case hotkeyRegisterFail(status: OSStatus)
-        case hotkeyUnregisterFail(status: OSStatus)
+        case cannotRegisterHotkey(status: OSStatus)
+        case cannotUnregisterHotkey(status: OSStatus)
     }
 }
diff --git a/source/Observatory/Observer/Hotkey/Observer.Hotkey.swift b/source/Observatory/Observer/Hotkey/Observer.Hotkey.swift
index 99f222e..22d3f84 100644
--- a/source/Observatory/Observer/Hotkey/Observer.Hotkey.swift
+++ b/source/Observatory/Observer/Hotkey/Observer.Hotkey.swift
@@ -112,14 +112,14 @@ open class HotkeyObserver: AbstractObserver {
         // Create universal procedure pointer, so it can be passed to C.
 
         let status: OSStatus = InstallEventHandler(GetApplicationEventTarget(), eventHandler, 1, &eventType, eventHotkeyHandlerPointer, &eventHandlerPointer)
-        guard status == Darwin.noErr else { throw Error.uppInstallFailed }
+        guard status == Darwin.noErr else { throw Error.cannotInstallUPP }
 
         return (eventHandlerPointer!, eventHotkeyHandlerPointer)
     }
 
     private func destructEventHandler(_ eventHandler: EventHandlerPointer, eventHotkeyHandler: EventHotkeyHandlerPointer) throws {
         let status: OSStatus = RemoveEventHandler(eventHandler)
-        guard status == Darwin.noErr else { throw Error.uppRemoveFail }
+        guard status == Darwin.noErr else { throw Error.cannotUninstallUPP }
 
         eventHotkeyHandler.deinitialize(count: 1)
         eventHotkeyHandler.deallocate()
@@ -143,9 +143,9 @@ extension HotkeyObserver {
 extension HotkeyObserver {
     public enum Error: Swift.Error {
         /// Cannot install universal procedure pointer.
-        case uppInstallFailed
+        case cannotInstallUPP
         /// Cannot remove universal procedure pointer.
-        case uppRemoveFail
+        case cannotUninstallUPP
     }
 }