Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a standard way to expose a way to review all of the forms when a package assembles multiple forms in separate packages #103

Closed
nonprofittechy opened this issue Apr 26, 2021 · 7 comments
Labels
enhancement New feature or request potentially revisit For low priority, closed issues, but not quite "wontfix"
Milestone

Comments

@nonprofittechy
Copy link
Member

This could also require changes in the Weaver, but people often don't have a way to tell the Weaver multiple forms will be included at that point.

@nonprofittechy
Copy link
Member Author

One of the things to consider is that someone might think they could edit the name separately, but actually there is one users object that is used to complete all of the forms.

@nonprofittechy
Copy link
Member Author

For now: just have the developer of the "umbrella" interview copy/paste the review blocks from the sub-forms.

@nonprofittechy nonprofittechy modified the milestones: Spring 2021, Future, Next May 5, 2021
@nonprofittechy
Copy link
Member Author

Another thought: we may want to add an "edit" button for each row that takes you to the review screen for that specific form.

@plocket
Copy link
Collaborator

plocket commented Jul 2, 2021

Does multiple documents refer to multiple YAML files?

@nonprofittechy
Copy link
Member Author

Related: #209

@nonprofittechy
Copy link
Member Author

I implemented this behavior in https://github.com/nonprofittechy/docassemble-HousingCodeChecklist/. I am not positive it needs to be standardized, but it feels like we have most of the elements to standardize it in place already. Adding something to the interview_metadata could be the only solution we need.

@plocket plocket changed the title Figure out a standard way to expose a way to review all of the forms when a package assembles multiple documents Figure out a standard way to expose a way to review all of the forms when a package assembles multiple YAML files Jul 2, 2021
@nonprofittechy nonprofittechy changed the title Figure out a standard way to expose a way to review all of the forms when a package assembles multiple YAML files Figure out a standard way to expose a way to review all of the forms when a package assembles multiple forms in separate packages Jul 21, 2021
@nonprofittechy
Copy link
Member Author

I think enough of this is in the fix to #209 that this is no longer appropriate. On balance, using the section links to edit answers is cumbersome and an overall review screen is more compatible with a mobile device, so adding a big feature for this doesn't make much sense. But #209 makes this possible if an author wants this behavior.

@nonprofittechy nonprofittechy added the potentially revisit For low priority, closed issues, but not quite "wontfix" label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request potentially revisit For low priority, closed issues, but not quite "wontfix"
Projects
None yet
Development

No branches or pull requests

2 participants