Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noexcept for some methods of abstract_message_box_t #89

Open
eao197 opened this issue Dec 19, 2024 · 0 comments
Open

noexcept for some methods of abstract_message_box_t #89

eao197 opened this issue Dec 19, 2024 · 0 comments
Assignees

Comments

@eao197
Copy link
Member

eao197 commented Dec 19, 2024

There are two methods of abstract_message_box_t that are not marked as noexcept: id() and type().

I don't remember why they do not have noexcept specifier and don't see any reasons why they are not noexcept. It seems to me that they can be used in noexcept contexts.

And it's hard to imagine an implementation of such methods that throws.

May be they have to be marked as noexcept?

If it has a sense then such a change can be made in v.5.9 to avoid breaking compatibility of abstract_message_box_t interface in 5.8-branch.

@eao197 eao197 self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant