Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete Concurrency Checking #19

Open
1 task done
PSchmiedmayer opened this issue Mar 29, 2024 · 1 comment
Open
1 task done

Complete Concurrency Checking #19

PSchmiedmayer opened this issue Mar 29, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@PSchmiedmayer
Copy link
Member

Problem

With Swift 6 approaching in a few months and nightly builds already being available we should ensure that all our packages are working well with all Swift concurrency checks.

Solution

Enable strict concurrency checking in the Swift Package in a PR and ensure that we don't have any warnings remaining in the packages as we develop new features or fix bugs from now.

The UI Testing App target should also enable Enable strict concurrency checking.

The corresponding PR should fix all related warnings when enabling strict concurrency checking.

Additional context

We should consider adding SWIFT_TREAT_WARNINGS_AS_ERRORS = YES to our general workflows to ensure all warnings are flagged as errors during our CI setup.

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@PSchmiedmayer PSchmiedmayer added enhancement New feature or request help wanted Extra attention is needed labels Mar 29, 2024
@PSchmiedmayer PSchmiedmayer mentioned this issue Mar 29, 2024
Open
24 tasks
@PSchmiedmayer PSchmiedmayer mentioned this issue Jul 1, 2024
Merged
1 task
@PSchmiedmayer
Copy link
Member Author

As part of fixing any concurrency errors, we should improve FHIRStore to be actor isolated instead of using a locking mechanism as introduced in #21.

PSchmiedmayer added a commit that referenced this issue Jul 1, 2024
@PSchmiedmayer
Fix Runtime Crash Due to Unlocked Access to Shared Properties (#21)
4357bd2 
# Fix Runtime Crash Due to Unlocked Access to Shared Properties

## ♻️ Current situation & Problem
- We have received crash reports that applications are crashing due to a
shared access to the resources property within the FHIR store.
- Closes #16 


## ⚙️ Release Notes 
- Adds a simple locking mechanism for the FHIR store. Should be updated
to an actor-isolated context as documented in #19.

## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Project Planning
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PSchmiedmayer