Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review hook_boot redirect to HTTPS #91

Open
mistermarco opened this issue Mar 14, 2012 · 1 comment
Open

Review hook_boot redirect to HTTPS #91

mistermarco opened this issue Mar 14, 2012 · 1 comment
Labels
6.x-3.x 7.x-3.x Cleanup

Comments

@mistermarco
Copy link
Member

hook_boot redirects the user to an HTTPS version of the site if he/she accesses the site through HTTP and has an WMDsecureLogin cookie (a flag that indicates they logged in at some point).

During the redirect, the URL is modified and the location is turned into one that uses ?q=
However, that doesn't seem to keep any of the other query parameters. Is this on purpose?
Why not just use request_uri?
@mistermarco
Copy link
Member Author

Also note the way we check for HTTPS being empty. Should we check to see if it's set first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6.x-3.x 7.x-3.x Cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mistermarco