Move URL-making functions out of WebAuthSession?

[mistermarco]

There are some functions in webauth.module that instantiate a new WebAuthSession for the only purpose of creating login and return URLs. The following variable and functions in WebAuthSession.inc are involved.

variables

authUrl
returnUrl

functions

makeAuthUrl
getLoginUrl
makeReturnUrl
getWebLogin

My question is whether these need to be part of a WebAuthSession object, or could be functions in webauth.module.

[joshkoenig]

In theory I think they can move, but it's a relatively large change. I would need to look into it more deeply to say for sure whether it's a good idea or not.

But definitely this would need to be done to insure we could get logins to work with a minimum of session creation. I missed the form_alter() on login block (which is on every page) before. :\