Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

st2-check-pylint-pack doesn't check if requirements installed successfully #11

Open
LindsayHill opened this issue Jan 5, 2017 · 0 comments

Comments

@LindsayHill
Copy link
Contributor

When make lint runs, it creates a virtual environment and installs any pip packages listed in requirements.txt.

If any of those packages fail to install, e.g. because additional system packages like libmlx2-dev are required, the script carries on, and runs pylint. I think it should exit if any packs fail to install.

Example output:

Command "/root/StackStorm/st2contrib/virtualenv/bin/python -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-GaoJ7u/lxml/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-xA8Jhj-record/install-record.txt --single-version-externally-managed --compile --install-headers /root/StackStorm/st2contrib/virtualenv/include/site/python2.7/lxml" failed with error code 1 in /tmp/pip-build-GaoJ7u/lxml/
--> No pylint issues found in actions.
--> No pylint issues found in sensors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant