Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR versions should be recognized as release candidates #673

Open
1 task done
GeorgEchterling opened this issue Feb 23, 2023 · 0 comments · May be fixed by #676
Open
1 task done

CR versions should be recognized as release candidates #673

GeorgEchterling opened this issue Feb 23, 2023 · 0 comments · May be fixed by #676

Comments

@GeorgEchterling
Copy link

🐛 Describe the bug

Hibernate uses CR as their marker for release candidates. RefreshVersions only recognizes RC as StabilityLevel.ReleaseCandidate. Because of this, the following configuration does not filter out Hibernate's release candidates as expected:

refreshVersions {
    rejectVersionIf {
        @Suppress("UnstableApiUsage")
        // Do not recommend upgrades from stable to unstable versions.
        candidate.stabilityLevel.isLessStableThan(current.stabilityLevel)
    }
}

⚠️ Current behavior

Versions such as 6.2.0.CR1and 6.2.0.CR2 are recognized as StabilityLevel.Stable.

✅ Expected behavior

Versions such as 6.2.0.CR1and 6.2.0.CR2 should be recognized as StabilityLevel.ReleaseCandidate.

💣 Steps to reproduce

  • Add any stable Hibernate dependency in the 6.1.X line.
  • Reject release candidates using rejectVersionIf.
  • RefreshVersions will still recommend upgrades to 6.2.0.CR1and 6.2.0.CR2.
GeorgEchterling pushed a commit to GeorgEchterling/refreshVersions that referenced this issue Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant