Separate staging from immediate IPFS integration #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nanthana2003
reviewed
Feb 4, 2024
|
|
||
| // Save the staged files in a temporary location (e.g., .statik/staging/) | ||
| const stagingPath = cwd + "/.statik/staging/"; | ||
| const stagingCID = await client.add(stagedFiles, { pin: false }); |
There was a problem hiding this comment.
Still Staging is done by adding files to IPFS
Previous commit or existing snapshot is not checked before creating the new snapshot, same file with no changes may get committed twice
Suggestion: Now the commit message can be written as a blank space by not writing anything within the quotes so we can also add a check point to check whether a proper commit message is written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2