Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script has weak SAS parsing logic [HELP WANTED] #17

Closed
Reinitialized opened this issue Mar 24, 2021 · 5 comments
Closed

Script has weak SAS parsing logic [HELP WANTED] #17

Reinitialized opened this issue Mar 24, 2021 · 5 comments

Comments

@Reinitialized
Copy link

Reinitialized commented Mar 24, 2021

It appears the issue is relating to weak logic surrounding SAS models. However, more test cases should be provided to confirm if this is indeed a protocol difference, or a difference in how manufacturers report SMART data.


It appears the script is incorrectly parsing smartctl results, as the script reports the following:
image

but sudo smartctl --all /dev/sda clearly shows the expected data
image

Expected behavior:
Correctly parse the results of smartctl so the script can function accordingly.

@Spearfoot
Copy link
Owner

You're using a SAS drive, and this tool has weak support for SAS drives -- because I don't own any to test with.
Example: the script looks for "Device Model", "Model Family", or "Model Number" to identify the disk model -- your SAS disk returns none of these, just "Product".
Another example: the script looks for "Serial Number" for the serial number -- your SAS disk uses lower-case 'n' ("Serial number"), so it misses that, too.

@Reinitialized
Copy link
Author

Alright, I'll do a fork and see if I can adapt it to handle SAS disks better. I currently only have the one model, but depending on how these go I may have others soon. I'll also change the title of this issue to reflect the problem, and it would be nice if you added a help-wanted label so we could see about getting others involved with a variety of models.

@Reinitialized Reinitialized changed the title Script appears to be incorrectly parsing smartctl results Script has weak SAS parsing logic Mar 24, 2021
@Reinitialized
Copy link
Author

Reinitialized commented Mar 24, 2021

Interestingly, it seems I've ran into an issue involving the reporting of SMART capabilities, as these HDDs return nothing. Is this normal?
image

@Reinitialized Reinitialized changed the title Script has weak SAS parsing logic Script has weak SAS parsing logic [HELP WANTED] Mar 29, 2021
@ciscam
Copy link

ciscam commented Nov 20, 2021

Seems I worked on that without noticing there is this open issue:
#22

I'll use this chance to say thank you @Spearfoot for saving me lots of time. I was just about to hack a little script together to burnin and log information on my 15 heterogenous drives, but you already invented that wheel in a nice and clean way. <3

@Reinitialized
Copy link
Author

Closed since work is already being done on #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants