We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note: Make sure to check out known issues (https://akv2k8s.io/troubleshooting/known-issues/) before submitting
Components and versions Select which component(s) the bug relates to with [X].
[ x ] Controller, version: 1.6.0 (docker image tag) [ ] Env-Injector (webhook), version: 1.6.0 (docker image tag) [ ] Other
1.6.0
Describe the bug When akv2k8s updates an existing k8s secret that has annotations and labels, the annotations and labels are removed.
Looks like annotations and labels are taken from the AzureKeyVaultSecret object instead of from the existing secret.
azure-key-vault-to-kubernetes/cmd/azure-keyvault-controller/controller/secret.go
Line 224 in 647b715
To Reproduce
apiVersion: v1 kind: Secret metadata: name: repo-github namespace: argocd labels: argocd.argoproj.io/secret-type: repository annotations: managed-by: argocd.argoproj.io data: dummy: YWJjCg== type: Opaque
apiVersion: spv.no/v2beta1 kind: AzureKeyVaultSecret metadata: name: dummy-secret namespace: argocd spec: output: secret: dataKey: dummy name: repo-github vault: name: myvault object: name: dummy type: secret
Expected behavior Akv2k8s should only update the secret data, not any other information on the object.
Workaround Set annotations and labels on AzureKeyVaultSecret object.
The text was updated successfully, but these errors were encountered:
faced the same problem
Sorry, something went wrong.
No branches or pull requests
Note: Make sure to check out known issues (https://akv2k8s.io/troubleshooting/known-issues/) before submitting
Components and versions
Select which component(s) the bug relates to with [X].
[ x ] Controller, version:
1.6.0
(docker image tag)[ ] Env-Injector (webhook), version:
1.6.0
(docker image tag)[ ] Other
Describe the bug
When akv2k8s updates an existing k8s secret that has annotations and labels, the annotations and labels are removed.
Looks like annotations and labels are taken from the AzureKeyVaultSecret object instead of from the existing secret.
azure-key-vault-to-kubernetes/cmd/azure-keyvault-controller/controller/secret.go
Line 224 in 647b715
To Reproduce
Expected behavior
Akv2k8s should only update the secret data, not any other information on the object.
Workaround
Set annotations and labels on AzureKeyVaultSecret object.
The text was updated successfully, but these errors were encountered: