Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Check doesn't work for Windows Versions of Webcord #484

Open
dreamsyntax opened this issue Nov 1, 2023 · 1 comment
Open

Update Check doesn't work for Windows Versions of Webcord #484

dreamsyntax opened this issue Nov 1, 2023 · 1 comment
Assignees
Labels
status:confirmed Issues that could be reproduced type:bug Something isn't working

Comments

@dreamsyntax
Copy link

dreamsyntax commented Nov 1, 2023

Description

The Linux versions of WebCord have a notification that appears a new version of WebCord is available.
The Windows versions of WebCord, ex WebCord-win32-x64-4.5.0.zip do not have this popup when a new version is released.

Suggestions

Add a notification like the Linux versions of WebCord to inform the user when an update is available.

Example of Linux:
image

@dreamsyntax dreamsyntax added the type:feat New feature or request label Nov 1, 2023
@SpacingBat3
Copy link
Owner

I think this is actually more a bug than lack of implementation. I honestly dunno why this works differently on Windows, but since it seems the entire update check is failing, I would blame the net API in Electron for returning an info that there's no network connection (since this prevents from check to happen at the first place) or failures around fetch API.

I'll probably add some verbose logging to it and test it on Windows.

@SpacingBat3 SpacingBat3 added type:bug Something isn't working status:confirmed Issues that could be reproduced and removed type:feat New feature or request labels Nov 4, 2023
@SpacingBat3 SpacingBat3 changed the title Add Update Check for Windows Versions of Webcord Update Check doesn't work for Windows Versions of Webcord Nov 4, 2023
@SpacingBat3 SpacingBat3 pinned this issue Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed Issues that could be reproduced type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants