Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel: Domain Items and Types should be links only if they don't already exist in domain #153

Open
bmcdougald opened this issue Jan 27, 2016 · 1 comment

Comments

@bmcdougald
Copy link
Contributor

If you open a page and click an extracted item to add it to the domain (while domain items toggle is set to on) it will highlight in the page AND the side panel (letting you know that that extracted item is "already a domain item" so you don't need to try and add it again. If you then go to a new page, the domain term will highlight on the page properly, but when the extracted items panel comes back it does not show the domain items that already exist as highlighted.

Since we do not disable or omit extracted items or types that are already added to the Domain, and we're not highlighting them to call attention to them already being part of the domain...it creates a situation where we can add the same term or type multiple times for the domain. This is less than desirable behavior.

@bmcdougald bmcdougald added the bug label Jan 27, 2016
@michaelsframe
Copy link

This original behavior was actually a bug. Revising title and functionality to reflect how it should work in new Firefox sidebar.

Domain Items and Domain Entity Types should only show as links if they do not already exist in the Domain. Once added they should be converted from links to labels.

@michaelsframe michaelsframe changed the title Panel: Domain Items may not highlight in panel on subsequent pages Panel: Domain Items and Types should be links only if they don't already exist in domain Feb 2, 2016
@michaelsframe michaelsframe added this to the 2.1.1 QPR milestone Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants