Fix S3267 FP: Cannot use local variable of byref-like type 'ReadOnlySpan<>' inside lambda expression

[dimon4egkl]

Description

S3267
Some suggestions to simplify the code by rewriting it using LINQ cannot be applied when ref struct types are involved.

Repro steps

ReadOnlySpan<char> stringToCompare = "example".AsSpan();
string[] stringValues = ["example", "another string"];
var isMatchFound = false;
// S3267: loop should be simplified to LINQ
foreach (var value in stringValues)
{
    if (value.AsSpan().Equals(stringToCompare, StringComparison.Ordinal))
    {
        isMatchFound = true;
        break;
    }
}

ReadOnlySpan is a ref struct and can not be used inside lambda expressions.

// Cannot use local variable 'stringToCompare' of byref-like type 'ReadOnlySpan<char>' inside lambda expression;
ReadOnlySpan<char> stringToCompare = "example".AsSpan(); 
string[] stringValues = ["example", "another string"];
var result = stringValues.Any(value => value .AsSpan().Equals(stringToCompare, StringComparison.Ordinal));

Expected behavior

I didn't expect any diagnostics to be emitted.

Actual behavior

False positive.

Known workarounds

#pragma warning disable S3267

Related information

• SonarCloud.io
• JetBrains Rider 2024.1.1
• dotnet 8.0.403
• SonarScanner for .NET version 2.3.2
• RedHat

[alex-meseldzija-sonarsource]

Hi there,
I believe this is a duplicate of #8430
Which we have reproduced here
Thanks for raising this!