Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If auth.authenticate throws error whole app crashes #99

Open
BOTKooper opened this issue Jan 18, 2023 · 0 comments
Open

If auth.authenticate throws error whole app crashes #99

BOTKooper opened this issue Jan 18, 2023 · 0 comments

Comments

@BOTKooper
Copy link

Just noticed that there is no try-catch blocks around await auth.authenticate(email, password, context) so due to the nature of express if that function throws - whole node process dies.

Question is - is this intentional decision (cannot find any mention in AdminJS documentation) or misunderstanding?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not crash when auth.authenticate call throws BOTKooper/adminjs-expressjs
1 participant
@BOTKooper