Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename strategies to have consistent naming #21

Open
zweistein opened this issue Apr 12, 2018 · 0 comments
Open

Rename strategies to have consistent naming #21

zweistein opened this issue Apr 12, 2018 · 0 comments
Assignees
@JessyVision
Labels
bug enhancement

Comments

@zweistein
Copy link
Contributor

zweistein commented Apr 12, 2018 •
edited
Loading

In GraspStrategy.msg there are strategy types named highly ambiguous like:
int32 STRATEGY_SLIDE_TO_EDGE = 20

This seems to be used in the CreateGeometryGraph.cpp line157 as a grasping type rather than slide. So a better name is STRATEGY_EDGE_GRASP like int32 STRATEGY_WALL_GRASP = 50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessyVision JessyVision

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zweistein @JessyVision