You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure there's a way to avoid some kind of redundancy here as long as wayland_client has a helper related to globals, and sctk needs a helper that provides additional functionality (for hotpluggable globals).
But it would be good to improve this if anyone has ideas.
I don't see a way we can remove this redundancy without expanding wayland-client's helpers into this scope or tell users of sctk to manually instantiate globals like wl_output
I guess this abstraction is useful in wayland-rs for things that are using wayland-rs without sctk?
Assuming it's thus necessary to have in client-toolkit, there might be a couple options:
Just don't use this wayland-client feature in sctk, and duplicate it (or wrap the wayland-client version, so the user of sctk doesn't directly call it)
Expand the scope of this in wayland-client in some way, and remove the need for a registry helper type in sctk
This seems to blur the boundry of what's in scope for wayland-client and for sctk
From what I understand, right now global handling is done in multiple steps:
waylad_client
:GlobalList
intercepts events and fills it's internalMutex<Vec<Global>>
. After the initial roundtrip it starts propagating new events.client-toolkit
:RegistryState
clones the list of globals fromGlobalList
and keeps it in sync.It seems that having two copies of
Vec<Global>
is redundant.The text was updated successfully, but these errors were encountered: