-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'turbolift update-prs' feature #65
Comments
JimNero009
changed the title
'trubolift update-prs' feature
'turbolift update-prs' feature
Aug 17, 2021
This could be combined together with #12 and #60, perhaps. e.g.
Thoughts? |
The set-draft is an excellent suggestion; As I pointed out in #12, setting a PR back to draft is not supported natively by the |
sledigabel
added a commit
that referenced
this issue
Jan 26, 2022
Relates to #65 Fixes #60 Relates to #67 This PR implements a global PR closing command. It introduces a new `update-prs` verb which has only one option at the moment: `--close`. It uses the same mechanism as in #67, looking at the PRs and identifying the one related to the campain, then closes it. It handles the case where there is no open PR.
rnorth
added a commit
that referenced
this issue
Jun 27, 2022
* Adds `update-prs` with `close` feature Relates to #65 Fixes #60 Relates to #67 This PR implements a global PR closing command. It introduces a new `update-prs` verb which has only one option at the moment: `--close`. It uses the same mechanism as in #67, looking at the PRs and identifying the one related to the campain, then closes it. It handles the case where there is no open PR. * Update after PR comments - typos - Readme addition Signed-off-by: Sebastien Le Digabel <[email protected]> Co-authored-by: Richard North <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've recently had a couple of situations where new information has come to light only after mass-raising a bunch of PRs. That new information would be useful to include in the PR description for the benefit of those that haven't yet go around to reviewing the PR, but turbolift (as far as I can tell) doesn't keep a track of the PRs it has raised. This isn't necessarily a problem, but it does mean that the only interaction I have with the PR stage is just the creation stage and I have to live with whatever description I had for ever more.
I'm thinking there could be a different option, or perhaps a flag, that executes code similar to that for create-pr, but is able to update the description of the PR given the content of local README.md file. The logic might be something like:
The text was updated successfully, but these errors were encountered: