Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For some reason this now opens on Java 11 in IntelliJ #41

Open
bombcar opened this issue Dec 4, 2021 · 5 comments
Open

For some reason this now opens on Java 11 in IntelliJ #41

bombcar opened this issue Dec 4, 2021 · 5 comments

Comments

@bombcar
Copy link
Contributor

bombcar commented Dec 4, 2021

I thought the build.gradle was supposed to inform IntelliJ what to use, but it's defaulting to 11 and I can't make it go back.

Command line ./gradew works fine - as do other GTNH mods.

@bombcar
Copy link
Contributor Author

bombcar commented Dec 4, 2021

Found it on this page:

image

weird that we can't hint it ...

@SinTh0r4s
Copy link
Owner

The isse is, that @TheElan found some elements in ForgeGradle, that cannot use the pipeline from Gradle 6 (Gradle will provide jdk as specified). So we had to roll back to the exception it now throws with java not equals to Java 8.

Gonna bring that feature back as soon as ForgeGradle agrees with it!

@TheElan
Copy link
Collaborator

TheElan commented Dec 4, 2021

The isse is, that @TheElan found some elements in ForgeGradle, that cannot use the pipeline from Gradle 6 (Gradle will provide jdk as specified). So we had to roll back to the exception it now throws with java not equals to Java 8.

Gonna bring that feature back as soon as ForgeGradle agrees with it!

lines I've removed have nothing to do with java 11, they were just incompatible toolchain feature introduced in 6.2 (iirc). So this should not have anything to do with IDEA. My guess that it might be inferring jvm version from gradle version

I think we can solve it with idea plugin like: https://stackoverflow.com/questions/49679931/how-can-i-use-the-gradle-idea-task-to-set-intellijs-default-settings

However according to the comment:

The only one catch: the plugin does not support the IDEA directory based project configuration layout, only the file based.

But it might've been resolved by now.

@TheElan
Copy link
Collaborator

TheElan commented Dec 4, 2021

There are also an eclipse version of it: https://docs.gradle.org/6.9.1/userguide/eclipse_plugin.html

and here are official idea plugin docs: https://docs.gradle.org/6.9.1/userguide/idea_plugin.html

@bombcar
Copy link
Contributor Author

bombcar commented Dec 4, 2021

I’ll take a look. It would be nice it we can make it open correctly by default even if we have to modify setupDecomp or add a .idea file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants