Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldArchive should archive v1 contracts beyond the v2 require height #1545

Closed
ChrisSchinnerl opened this issue Sep 18, 2024 · 0 comments · Fixed by #1586
Closed

shouldArchive should archive v1 contracts beyond the v2 require height #1545

ChrisSchinnerl opened this issue Sep 18, 2024 · 0 comments · Fixed by #1586
Assignees
@peterjan
Milestone
v2.0.0

Comments

@ChrisSchinnerl
Copy link
Member

No description provided.

@ChrisSchinnerl ChrisSchinnerl converted this from a draft issue Sep 18, 2024
@ChrisSchinnerl ChrisSchinnerl moved this from Triage to Todo in Sia Sep 18, 2024
@ChrisSchinnerl ChrisSchinnerl added this to the v2 milestone Sep 19, 2024
This was referenced Sep 27, 2024
Merged
Merged
@peterjan peterjan self-assigned this Oct 3, 2024
@peterjan peterjan moved this from Todo to In Review in Sia Oct 3, 2024
ChrisSchinnerl added a commit that referenced this issue Oct 21, 2024
@ChrisSchinnerl
Fix scan error when fetching archived contracts (#1585)
eeeb7b2 
This PR fixes a scan error when fetching contracts using the new filter
mode `api.ContractFilterModeArchived`.

Related #1545
ChrisSchinnerl added a commit that referenced this issue Oct 30, 2024
@ChrisSchinnerl
Archive v1 contracts if blockheight is passed V2 require height (#1586)
e4fe42d 
NOTE: can't write an integration test for it because the host doesn't
allow renewing contracts after the V2 require height, this means that
the contractor will always archive contracts because they are expired
and we can't mine passed the V2 require height

Fixes #1545
@github-project-automation github-project-automation bot moved this from In Review to Done in Sia Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterjan peterjan

Labels
None yet
Projects
Sia
Status: Done
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Archive v1 contracts if blockheight is passed V2 require height SiaFoundation/renterd
2 participants
@peterjan @ChrisSchinnerl