-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event markers to "over time" graphs #271
Comments
Besides maintaining and using It probably takes some effort to maintain the list of events manually, and even random dependabot changes (which will likely not have manual event markers) may sometimes impact the performance, so I would like such automated markers. |
Yeah that's a good point. We could use something like We can probably start by just generating that data when we generate those graphs. The hard part will be keeping the graphs usable. |
This is a good proposal and I agree that using the git log is probably the best solution for this 👍 |
There is a "YJIT Results Over Time" section at the bottom of the home page (and other "over time" graphs beyond that).
The activerecord graph changed significantly because the benchmark code itself changed.
We already have the "events.json", it would be nice if the over time graph included markers for these events that you could easily see if there is a known event that explains the graph change.
The text was updated successfully, but these errors were encountered: