Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme block JSON preset completion/hover support #623

Open
Tracked by #545
charlespwd opened this issue Nov 28, 2024 · 0 comments
Open
Tracked by #545

Theme block JSON preset completion/hover support #623

charlespwd opened this issue Nov 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@charlespwd
Copy link
Contributor

charlespwd commented Nov 28, 2024

Do this one after #625

We want completion of presets.[].(recursive blocks.[]).settings keys & maybe values?

Requirements:

  • Key completion of presets.[].blocks.[].settings (same file if local blocks are used, otherwise other file)
  • Key completion of presets.[].blocks.[].blocks.[].settings (other file)
  • ... and so on :) It's recursive
{% schema %}
{
  "name": "Header Announcement",
  "blocks": [{ "type": "slide" }],
  "settings": [
    {
      "type": "text",
      "id": "my-id",
      "label": "Text"
    }
  ],
  "presets": [
    {
      "name": "Header Announcement",
      "blocks": [
        {
          "type": "slide",
          "settings": {
            "█": "<-- should complete blocks/slide.liquid setting ids"
          },
          "blocks": [
            {
              "type": "group",
              "settings": {
                "█": "<-- should compelte blocks/group.liquid setting ids"
              }
            }
          ]
        }
      ]
    }
  ]
}
{% endschema %}
@graygilmore graygilmore added the enhancement New feature or request label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants