Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "Go to declaration" of translations #563

Open
1 task done
n-for-all opened this issue Nov 6, 2024 · 1 comment
Open
1 task done

Support for "Go to declaration" of translations #563

n-for-all opened this issue Nov 6, 2024 · 1 comment
Assignees
Labels

Comments

@n-for-all
Copy link

Is your feature request related to a problem? Please describe.
It is showing the value currently, for example "t:sections.slider.presets.name" will show "Slider" on hover, is it possble once we cmd+click on the translation to take us there

Describe the solution you'd like
CMD+Click to browse to translation key value pair in shopify json file

Describe alternatives you've considered
Json Editor, i18 editor

Checklist

  • I have checked and made sure that the proposal adheres to this plugin's principles

Additional context

@charlespwd
Copy link
Contributor

That would be very cool indeed. And now that we have the virtual file system, this is possible even in web contexts.

Solution breadcrumbs:

  • This should probably be solved by a Go to declaration client->server request.
  • The default locale file should be preloaded in the document manager (so that you have access to its AST)
  • Send the user to the correct node position from the AST

@charlespwd charlespwd changed the title CMD+Click to browse to translation key value pair in shopify json file Support for "Go to declaration" of translations Nov 7, 2024
@jamesmengo jamesmengo self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants