-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve workspace/symbol request's performance #2660
Comments
If I understand it correctly, Also, excluding all gems from indexing will seriously degrade the functionality of other features like go-to-definition, autocompletion...etc. so it's not something we'll encourage users to do and it's rarely the right solution to the issue. |
Yes, this is for the
I checked with v0.20.0 and the performance difference is still pretty much the same.
I understand that this degrades the go-to definition and autocomplete functionality for external gems. Personally, the performance hit of including all these gems is so annoying that I don't care if I have autocomplete on them or not. I suspect other developers are affected as well, they probably just don't care about editor latency as much as I do or they would have excluded all the gems like I did. I understand if this is not a setting that |
I agree that we can possibly improve the performance of the But I also need to be honest that given our team's current backlog, this will be low on our list for at least a while. That said, if you want to investigate what's causing the slowdown, PRs are welcome 🙂 |
I have checked that this feature is not already implemented
Use case
The performance of the global go to symbol in ruby-lsp is noticeably worse when not excluding any gems than when excluding every gem.
Here are some short videos showing the difference:
excluding-all-gems.mp4
excluding-no-gems.mp4
Currently, if I want to exclude every gem, I'm forced to list them all in my editor's config file: https://github.com/gmcabrita/dotfiles/blob/f7b8d85449b4f6da3acbc7428548ceb4ca29f999/.config/zed/settings.json#L137-L585.
I also have to update that list as time goes on and new gems are added to an existing project, or I jump to a new project that has gems I am not currently ignoring.
Providing a setting to exclude all gems without having to list them would be a nice improvement.
Description
Possibly support one of these in the editor settings, ensuring that no gems are ever processed/indexed:
or
Implementation
No response
The text was updated successfully, but these errors were encountered: