Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Formatting causes ListViewCommandSet extension to be always enabled #10084

Open
1 of 9 tasks
OverkillTV opened this issue Jan 17, 2025 · 0 comments
Open
1 of 9 tasks
Labels
type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.

Comments

@OverkillTV
Copy link

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

Declarative list formatting

Developer environment

Windows

What browser(s) / client(s) have you tested

  • 💥 Internet Explorer
  • 💥 Microsoft Edge
  • 💥 Google Chrome
  • 💥 FireFox
  • 💥 Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

Additional environment details

  • SPFx version: 1.19.0

Describe the bug / error

custom ListViewCommandSet extension disable status is being affected by view formatting "commandBarProps" property even if it is not being used anywhere in the commandBarProps.
This is only happens in Document Libraries.

Video

Steps to reproduce

  1. Create a custom ListViewCommandSet extension with the command being disabled by default (.disabled = true)
  2. Set RegistrationId to 101 to target Document Libraries
  3. Add any commandBarProps formatting to the view (commands can be left blank: "commands": [])
  4. Reload the document library to check the custom command is still enabled.
  5. Remove the view formatting and the custom ListView Command will be disabled.

Expected behavior

Custom ListViewCommandSet disabled status should only be affected with view formatting when the command is being set in the view formatting.

@OverkillTV OverkillTV added the type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Projects
None yet
Development

No branches or pull requests

1 participant