Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make build arguments become configurable #36

Open
ShotaKitazawa opened this issue Jul 23, 2023 · 1 comment
Open

make build arguments become configurable #36

ShotaKitazawa opened this issue Jul 23, 2023 · 1 comment

Comments

@ShotaKitazawa
Copy link

ShotaKitazawa commented Jul 23, 2023 •
edited
Loading

I want to configure the build arguments as the following.

  • weaver.toml
[kube]
image = "kanatakita/dreamkast-weaver"
buildArgs = ["--load"]  # this line

I would like to use this feature in the case of the following.

  • in case of using buildx, we should specify --load option to docker build command
  • for granting additional tag
  • and so on...
@ShotaKitazawa
Copy link
Author

I created the PR #35. Please review it if your hands are free!

@ShotaKitazawa ShotaKitazawa mentioned this issue Jul 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShotaKitazawa