Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links don't work in a item label with a dot (.) or a double dot (:) #15

Open
ivanhercaz opened this issue Apr 1, 2018 · 4 comments
Open
Assignees
Labels

Comments

@ivanhercaz
Copy link

First of all, thank you very much @mwjames for develop this awesome extension. Very useful and easy to use!

Setup and configuration

  • Mermaid version: 1.0.1
  • MediaWiki version: 1.30.0
  • PHP version: 7.1.15
  • Database system and version: 5.6.39-cll-lve

Issue

The problem is that I can't use dots or double dots in the labels of the items (check the below link to the SMW Sandbox). I installed Mermaid as the documentation said, it works fine at this moments, excepting this little error.

This is the only trace in the console that I have directly identified with Mermaid:

JQMIGRATE: Migrate is installed with logging active, version 3.0.1-pre  load.php:10295:4
JQMIGRATE: jQuery.fn.delegate() is deprecated  load.php:10344:4
console.trace():  load.php:10346
	migrateWarn http://cultport.ivanhercaz.com/load.php:10346:5
	.delegate http://cultport.ivanhercaz.com/load.php:10760:3
	delegate http://cultport.ivanhercaz.com/extensions/SemanticMediaWiki/res/jquery/jquery.qtip.js:1387:2
	<anónimo> http://cultport.ivanhercaz.com/extensions/SemanticMediaWiki/res/jquery/jquery.qtip.js:1660:2
	resolve/</mightThrow http://cultport.ivanhercaz.com/load.php:3583:21
	resolve/</process< http://cultport.ivanhercaz.com/load.php:3651:12
Use of "mermaid" is deprecated. Use mw.config instead.  load.php:11392:8
Use of "mermaid" is deprecated. Use mw.config instead.  load.php:11385:8
Use of "mermaid" is deprecated. Use mw.config instead. load.php:11385:8
Use of "mermaid" is deprecated. Use mw.config instead. load.php:11385:8

Steps to reproduce the observation: Mermaid Test - graph with links with dots in labels.

Regards,
Iván

@s7eph4n
Copy link

s7eph4n commented Apr 1, 2018

This is what I get:
image

@mwjames
Copy link
Contributor

mwjames commented Apr 1, 2018 via email

@kghbln kghbln added the upstream label Apr 1, 2018
@kghbln
Copy link
Member

kghbln commented Feb 18, 2019

Mermaid 2.0.0 has just been released. If I interpret correctly this issue should be resolved now that the Mermaid extension ships with mermaid 8.0.0. Anyways since it is an upsteam issue the Mermaid extensions cannot do anything about it.

@kghbln kghbln closed this as completed Feb 18, 2019
@gesinn-it-gea
Copy link
Member

Issue still occurs with Mermaid 2.1.0 (last version supporting MW 1.31) when having a colon (:) in the title.

TODO:

  • test with current Mermaid 3.0.1 on MW 1.35
  • heck, if this is covered by a test

@gesinn-it-gea gesinn-it-gea reopened this Nov 9, 2021
@gesinn-it-gea gesinn-it-gea self-assigned this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants