From 9c3acf58566516e57048141e029eff7a8785e0fd Mon Sep 17 00:00:00 2001
From: Brendan Galloway <brendan@flanksource.com>
Date: Thu, 14 Nov 2024 11:51:15 +0200
Subject: [PATCH] fix: move slack env declaration out of otel logic

---
 helm-chart/sefaria-project/templates/rollout/web.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/helm-chart/sefaria-project/templates/rollout/web.yaml b/helm-chart/sefaria-project/templates/rollout/web.yaml
index 57c6668d6f..8b5837a08c 100644
--- a/helm-chart/sefaria-project/templates/rollout/web.yaml
+++ b/helm-chart/sefaria-project/templates/rollout/web.yaml
@@ -116,12 +116,12 @@ spec:
                 fieldPath: spec.nodeName
           - name: OTEL_RESOURCE_ATTRIBUTES
             value: k8s.container.name=app,k8s.deployment.name={{ .Values.deployEnv }}-web,k8s.namespace.name={{ .Release.Namespace }},k8s.node.name=$(OTEL_RESOURCE_ATTRIBUTES_NODE_NAME),k8s.pod.name=$(OTEL_RESOURCE_ATTRIBUTES_POD_NAME)
+          {{- end }}
           - name: SLACK_URL
             valueFrom:
               secretKeyRef:
-                name: { { template "sefaria.secrets.slackWebhook" . } }
+                name: {{ template "sefaria.secrets.slackWebhook" . }}
                 key: slack-webhook
-          {{- end }}
         envFrom:
           {{- if .Values.tasks.enabled }}
           - secretRef: