From 1ba62ecaee99259905607dc4855dcd8ff34230f5 Mon Sep 17 00:00:00 2001 From: Tyler Erickson Date: Tue, 11 Jun 2024 14:56:01 -0600 Subject: [PATCH] clean: Cleaning up old TODO comments Cleaning up old TODO comments that were resolved long ago, not really a TODO and converted to a comment. Signed-off-by: Tyler Erickson --- include/openseachest_util_options.h | 8 ++++---- src/EULA.c | 2 +- src/openseachest_util_options.c | 6 +++--- subprojects/opensea-common | 2 +- subprojects/opensea-operations | 2 +- subprojects/opensea-transport | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/openseachest_util_options.h b/include/openseachest_util_options.h index 889c159..9811c06 100644 --- a/include/openseachest_util_options.h +++ b/include/openseachest_util_options.h @@ -54,7 +54,7 @@ extern "C" UTIL_EXIT_FILE_ALREADY_EXISTS, UTIL_EXIT_NEED_ELEVATED_PRIVILEGES, UTIL_EXIT_NOT_ENOUGH_RESOURCES, - //TODO: More generic exit codes go here + //More generic exit codes go here UTIL_EXIT_ERROR_WRITING_FILE, //added 5/19/20 //Tool specific exit codes go here UTIL_TOOL_SPECIFIC_STARTING_ERROR_CODE = 32,//Use this value in a tool to start the tool's specific error code enumeration @@ -1821,7 +1821,7 @@ extern "C" bool forceUppercase; bool forceLowercase; bool invertCase; - //TODO: add other modifications as we find or hear other that work with some odd BIOS chips. + //add other modifications as we find or hear other that work with some odd BIOS chips. }ataSecPWModifications; #define ATA_SECURITY_PASSWORD_MODIFICATIONS passwordModificationType #define ATA_SECURITY_PASSWORD_MODIFICATIONS_VAR ataSecPWModifications ATA_SECURITY_PASSWORD_MODIFICATIONS = { false, false, false, false, false, false, false, false, false, false }; @@ -1840,7 +1840,7 @@ extern "C" #define ATA_SECURITY_USING_MASTER_PW_LONG_OPT_STRING "ataSecPassType" #define ATA_SECURITY_USING_MASTER_PW_LONG_OPT { ATA_SECURITY_USING_MASTER_PW_LONG_OPT_STRING, required_argument, NULL, 0 } - //TODO: This needs to handle the request to do secure erase AND which TYPE of secure erase + //This needs to handle the request to do secure erase AND which TYPE of secure erase #define ATA_SECURITY_ERASE_OP performATASecurityErase #define ATA_SECURITY_ERASE_OP_VARS \ bool ATA_SECURITY_ERASE_OP = false; \ @@ -1925,7 +1925,7 @@ extern "C" #define SCSI_MP_SAVE_LONG_OPT_STRING "scsiMPSave" #define SCSI_MP_SAVE_LONG_OPT { SCSI_MP_SAVE_LONG_OPT_STRING, required_argument, NULL, 0 } - //show scsi mode page (TODO: different output modes) output modes: classic vs "neat" or some other name... + //show scsi mode page output modes: classic vs "neat" or some other name... #define SCSI_SHOW_MP_OP showSCSIModePage #define SCSI_SHOW_MP_PAGE_NUMBER showModePageNumber #define SCSI_SHOW_MP_SUBPAGE_NUMBER showModeSubPageNumber diff --git a/src/EULA.c b/src/EULA.c index 9a6bd7c..1c4ec6c 100644 --- a/src/EULA.c +++ b/src/EULA.c @@ -761,7 +761,7 @@ void print_Open_Source_Licenses(void) #endif #endif #elif defined (__sun) || defined (_AIX) - //TODO: Any special license for system libc/etc that needs to be shown. Cannot easily identify one at this time - TJE + //Any special license for system libc/etc that needs to be shown. Cannot easily identify one at this time - TJE #else #error Please update #if for system library licenses! #endif diff --git a/src/openseachest_util_options.c b/src/openseachest_util_options.c index 46ad493..bd1a47c 100644 --- a/src/openseachest_util_options.c +++ b/src/openseachest_util_options.c @@ -103,7 +103,7 @@ void print_Elevated_Privileges_Text(void) #if defined (_WIN32) printf("In Windows, open the Command Prompt using \"Run as administrator\".\n"); #elif defined (__unix__) || defined(__APPLE__) - //TODO: handle the various linux/unix/unix-like OSs with more ifdefs here + //handle the various linux/unix/unix-like OSs with more ifdefs here #if defined (__linux__) #if defined (VMK_CROSS_COMP) printf("In ESXi, put sudo before the command. This may require inputting your login password.\n"); @@ -118,7 +118,7 @@ void print_Elevated_Privileges_Text(void) #elif defined (__sun) printf("In Solaris, put sudo before the command. This may require inputting your login password.\n"); printf("In Solaris, log in to a root terminal (su), then execute the command. This requires the root password.\n"); -#else //generic unix/unix-like case //TODO: Add more OS specific ifdefs to customize messages above +#else //generic unix/unix-like case //Add more OS specific ifdefs to customize messages above printf("In Linux/Unix, put sudo before the command. This may require inputting your login password.\n"); printf("In Linux/Unix, log in to a root terminal (su), then execute the command. This requires the root password.\n"); #endif @@ -245,7 +245,7 @@ void print_SeaChest_Util_Exit_Codes(int numberOfToolSpecificExitCodes, ptrToolSp printf("\t%d = Cannot Open File\n", UTIL_EXIT_CANNOT_OPEN_FILE); printf("\t%d = File Already Exists\n", UTIL_EXIT_FILE_ALREADY_EXISTS); printf("\t%d = Need Elevated Privileges\n", UTIL_EXIT_NEED_ELEVATED_PRIVILEGES); - //TODO: more generic exit code help above this comment. Tool specific exit codes in if statement below + //more generic exit code help above this comment. Tool specific exit codes in if statement below if (numberOfToolSpecificExitCodes > 0 && toolSpecificExitCodeList) { printf("\t---%s specific exit codes---\n", toolName); diff --git a/subprojects/opensea-common b/subprojects/opensea-common index 00b8dd3..1707e6c 160000 --- a/subprojects/opensea-common +++ b/subprojects/opensea-common @@ -1 +1 @@ -Subproject commit 00b8dd3de7427b1962f3495ff7e09372d1ffcb5a +Subproject commit 1707e6cf88263e8a6f5d112c4d7dbf32c12b526c diff --git a/subprojects/opensea-operations b/subprojects/opensea-operations index d3efca8..f4c7a80 160000 --- a/subprojects/opensea-operations +++ b/subprojects/opensea-operations @@ -1 +1 @@ -Subproject commit d3efca8781970ad59e51f24e5151fa21757e33d9 +Subproject commit f4c7a80b6e1c0b1259ea41026ec3a17e23200f3b diff --git a/subprojects/opensea-transport b/subprojects/opensea-transport index 5bf1b96..68c9830 160000 --- a/subprojects/opensea-transport +++ b/subprojects/opensea-transport @@ -1 +1 @@ -Subproject commit 5bf1b962f86a0d212dce071b623b0a35e7231461 +Subproject commit 68c9830cc8df11982307584ba43fbd68272e879d