Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

Add a favicon. #20

Open
forevertoofr opened this issue May 9, 2020 · 15 comments
Open

Add a favicon. #20

forevertoofr opened this issue May 9, 2020 · 15 comments

Comments

@forevertoofr
Copy link
Member

forevertoofr commented May 9, 2020

The website have no one favicon. Maybe add one ? I will try to code it. I know who then.

@ghost
Copy link

ghost commented May 9, 2020

You can make a favicon pretty easily. I think it works with GitHub pages by just making a file called favicon.ico

@forevertoofr
Copy link
Member Author

Yeah but you can add a thing in the code if not GitHub pages.

@retronbv
Copy link

retronbv commented May 9, 2020

the website is deployed with firebase (i think) so just make a pull request with a favicon and the code in index.html

@moeenio
Copy link
Member

moeenio commented May 9, 2020

In fact, favicon.ico alone works, no matter github pages or not, bc browsers will automatically try to get /favicon.ico (and that's how you have favicons when viewing non-html stuff like an image). Although you should include it in code.

@forevertoofr
Copy link
Member Author

If i add the favicon on a other website (mine) cause i don't know how to add images + edit a file in a pull request can i ?

@moeenio
Copy link
Member

moeenio commented May 10, 2020

To add an image to a Git repository, clone it to your computer, add the file to the folder, stage and commit. If you want to do it through GitHub's web interface, just drag it and drop it onto your repository's page (but do it on a branch!) tho I highly recommend you to use GitHub Desktop, it makes it way easier to use git.

@forevertoofr
Copy link
Member Author

Yeah on my old pc i used it. Thanks for the tip @locness3 !

@micahlt
Copy link
Member

micahlt commented May 10, 2020 via email

@moeenio
Copy link
Member

moeenio commented May 10, 2020

Some workflows are way eaiser with github desktop (which btw hasn't anything to do with git itself), like modifying someone else's PR.

@grngxd
Copy link
Member

grngxd commented Aug 11, 2020

@locness3 I seriously prefer the git CLI to the desktop version. Idk why, I'm weird xD

On Sun, May 10, 2020, 1:11 AM Locness @.***> wrote: To add an image to a Git repository, clone it to your computer, add the file to the folder, stage and commit. If you want to do it through GitHub's web interface, just drag it and drop it onto your repository's page (but do it on a branch!) tho I highly recommend you to use GitHub Desktop, it makes it way easier to use git. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG33HKMBW47MIKUXDZN2EXDRQZARFANCNFSM4M4XBSEQ .

same lol

@ghost
Copy link

ghost commented Aug 26, 2020

Try adding the image to the repo then update every .html file I think

@micahlt
Copy link
Member

micahlt commented Aug 26, 2020

@hhbo62 We know how to add one, but work on this project is suspended.

@ghost
Copy link

ghost commented Aug 26, 2020

Oh why was it suspended?

@moeenio
Copy link
Member

moeenio commented Aug 27, 2020

We're working on our mobile client, https://github.com/Scratch-Client-4/mobile

@ghost
Copy link

ghost commented Aug 31, 2020

‘K, get it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants