Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt common code for setting "scalingFactor" and "value" keys #538

Open
pp-mo opened this issue Sep 10, 2024 · 1 comment
Open

Adopt common code for setting "scalingFactor" and "value" keys #538

pp-mo opened this issue Sep 10, 2024 · 1 comment

Comments

@pp-mo
Copy link
Member

pp-mo commented Sep 10, 2024

As for example #205, but some general functionality.
Probably something like scalefactor_and_value(value, min_factor=0, max_factor=7)

A fair bit of work to apply this everywhere, naturally.
But we use currently use fixed values almost everywhere, which is just a limitation waiting to bite someone (i.e. values saved with unexpectedly limited precision)

@pp-mo
Copy link
Member Author

pp-mo commented Oct 8, 2024

See also : #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant