Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit hook for license headers? #22

Open
rcomer opened this issue Feb 25, 2024 · 5 comments
Open

Pre-commit hook for license headers? #22

rcomer opened this issue Feb 25, 2024 · 5 comments

Comments

@rcomer
Copy link
Member

rcomer commented Feb 25, 2024

📰 Custom Issue

Over at SciTools/cf-units#364 (comment), @pelson suggested that the test_coding_standards.py module would be better as a pre-commit hook. I found this insert-license is a supported hook.

@trexfeathers
Copy link
Contributor

Interesting idea 🙂. How would you propose converting all the other tests that are in the test_coding_standards module?

@rcomer
Copy link
Member Author

rcomer commented Feb 26, 2024

Heh, I hadn't clocked that Iris has other tests in there. cf-units only has the license header test, which is repeated all over SciTools and is going a bit wrong in Cartopy SciTools/cartopy#2278.

@rcomer
Copy link
Member Author

rcomer commented Feb 26, 2024

Is there a better place to put issues that affect multiple SciTools repos?

@trexfeathers
Copy link
Contributor

Is there a better place to put issues that affect multiple SciTools repos?

SciTools/.github

@rcomer
Copy link
Member Author

rcomer commented Feb 26, 2024

Thanks @trexfeathers - looks like I don't have permissions there so I can't transfer the issue. Please move it if you wish 👍

@trexfeathers trexfeathers transferred this issue from SciTools/iris Feb 26, 2024
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants