Replace Expronicon with Moshi #3354
Draft
+38
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this is breaking, unfortunately |
|
What is breaking exactly? I know the tests are failing in this draft PR because this needs SciML/SciMLBase.jl#922 first. And to avoid that breaking MTK I made #3353, which should be merged first. I was hoping this way it wouldn't be breaking. |
|
Are Moshi.jl ADTs matchable via MLStyle? |
|
Both Moshi and MLStyle support extensible pattern matching, so probably that can be made to work. Where is https://thautwarm.github.io/MLStyle.jl/latest/syntax/pattern.html#custom-patterns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because this would require a release and new minimum compat on SciMLBase with SciML/SciMLBase.jl#922.
This not only adapts to SciMLBase changes but also removes Expronicon from ModelingToolkit, where it was used for
InferredClockand a match insampletime.This doesn't get rid of MLStyle, which is used for pattern matching as well, but perhaps it would make sense as a follow up to start using Moshi for that as well.