Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Symlinks not detected as directories #20

Open
krlhBlupine opened this issue Mar 8, 2024 · 3 comments · May be fixed by #21
Open

[Feature Request] Symlinks not detected as directories #20

krlhBlupine opened this issue Mar 8, 2024 · 3 comments · May be fixed by #21
Assignees
@SalOrak
Labels
enhancement New feature or request

Comments

@krlhBlupine
Copy link

I have three or four projects all symlinked into a folder that I want to add to my Whaler config, but it doesn't seem to detect them as navigable. I think this is down to an issue with plenary.scandir, where I've also created an issue.

mkdir ~/notebooks/one
ln -s ~/other/two ~/notebooks/two

Whaler only displays notebook one.
@SalOrak
Copy link
Owner

SalOrak commented Mar 8, 2024

Hi @krlhBlupine! Thank you for the suggestion.

Even though I don't see why you would use symlinks instead of aliases directly I understand it can be useful.

I'm implementing it and I will add a PR to plenary regarding your issue!

Again, thank you and I hope you are enjoying Whaler.nvim.

SalOrak added a commit that referenced this issue Mar 8, 2024
@SalOrak
feat(#20): directory links are now added to the list
0eaa306
@SalOrak SalOrak self-assigned this Mar 8, 2024
@SalOrak SalOrak added the enhancement New feature or request label Mar 8, 2024
@SalOrak SalOrak mentioned this issue Mar 8, 2024
Open
@SalOrak
Copy link
Owner

SalOrak commented Mar 8, 2024

Hi again, the feature is implemented in the branch #20-feat-add-link-directories.
I'm still doing tests but it should be working. Make sure your links are absolute links, otherwise whaler won't be able to properly display the directory.

Once the feature is merged I'll close this.

@krlhBlupine
Copy link
Author

Thanks so much!

@SalOrak SalOrak linked a pull request Mar 13, 2024 that will close this issue
Open
@SalOrak SalOrak linked a pull request Jul 15, 2024 that will close this issue
[feat] Add symbolic link as directories. #21
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SalOrak SalOrak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feat] Add symbolic link as directories. SalOrak/whaler.nvim
2 participants
@SalOrak @krlhBlupine