Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid, Tex, std::vector and Eigen #412

Closed
dlyr opened this issue Feb 24, 2019 · 3 comments
Closed

Grid, Tex, std::vector and Eigen #412

dlyr opened this issue Feb 24, 2019 · 3 comments
Labels
Core Related to Ra::Core todo

Comments

@dlyr
Copy link
Contributor

dlyr commented Feb 24, 2019

I just notice that Ra::Core:::Grid use plain std::vector, which is fine in general, but not for Eigen types
as stated here.

std::vector<T> m_data;

Do not know how to fixit, maybe a partial template specialization or add EIGEN_DEFINE_STL_VECTOR_SPECIALIZATION in RaCore.hpp ?

@nmellado
Copy link
Contributor

There is a functionality clash between Grid and a new structure called Volume which generalize the concept to functional representations, sparse and dense grid storage. Volume are currently tested in another branch, but hopefully I should be able to submit it soon.

So, just to say: we could try to solve this problem with the Volume implementation, and replace Grid by this one. Instead of doing this twice.

Another remark, the concepts implemented for Volume also stand for 2D textures. So we could have a n-dimensional abstraction, explicitely specialized for the 2D and 3D case.

@stale
Copy link

stale bot commented Jul 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix PR/Issue that will not be fixed label Jul 24, 2019
@stale stale bot closed this as completed Aug 7, 2019
@dlyr dlyr added Core Related to Ra::Core todo and removed wontfix PR/Issue that will not be fixed labels Jan 27, 2021
@dlyr dlyr reopened this Jan 27, 2021
@dlyr
Copy link
Contributor Author

dlyr commented Jan 18, 2022

Some sort of duplicate of #797, so I close this one.

@dlyr dlyr closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Related to Ra::Core todo
Projects
None yet
Development

No branches or pull requests

2 participants