Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general prod2_unary algorithm #614

Open
1 of 4 tasks
SSoelvsten opened this issue Feb 19, 2024 · 1 comment
Open
1 of 4 tasks

Add general prod2_unary algorithm #614

SSoelvsten opened this issue Feb 19, 2024 · 1 comment
Assignees
Labels
✨ code quality Uncle Bob would be proud 📁 internal This is where the ✨magic✨happens

Comments

@SSoelvsten
Copy link
Owner

SSoelvsten commented Feb 19, 2024

The core logic for quantify sweeps can be reused for variable reordering. Hence...

  • Rename prod2 into prod2_binary
  • Move the logic for sweeps in quantification (with random access and with priority queues) into its own separate header, prod2_unary. This does not include anything particular to quantification, partial quantification, pruning, or repeated transposition.
    • Reuse as much as is possible for the version in quantification.
  • Move the boolean operator inside of the stateful policy ( done in Preliminary hack to approximate #162 optimisation inside of Quantify #618 )
@SSoelvsten SSoelvsten added ✨ code quality Uncle Bob would be proud 📁 internal This is where the ✨magic✨happens labels Feb 19, 2024
@SSoelvsten SSoelvsten added this to the v2.2 : Variable Reordering milestone Feb 19, 2024
@SSoelvsten SSoelvsten self-assigned this Feb 19, 2024
@SSoelvsten SSoelvsten removed their assignment Apr 28, 2024
@SSoelvsten
Copy link
Owner Author

SSoelvsten commented Apr 28, 2024

As long as the quantification algorithm has to support (repeated) partial quantification, I think this generalization will result in an insurmountable mess. Better is to only try and extract as much as is possible. That is, we will probably have to still have the sweep logics for quantification.

@SSoelvsten SSoelvsten changed the title Generalise quantify into prod2_unary Add general prod2_unary algorithm Apr 28, 2024
@SSoelvsten SSoelvsten self-assigned this Apr 28, 2024
@SSoelvsten SSoelvsten reopened this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ code quality Uncle Bob would be proud 📁 internal This is where the ✨magic✨happens
Projects
None yet
Development

No branches or pull requests

1 participant