Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make_request<...>(...) functions #613

Open
3 tasks
SSoelvsten opened this issue Feb 19, 2024 · 0 comments
Open
3 tasks

Add make_request<...>(...) functions #613

SSoelvsten opened this issue Feb 19, 2024 · 0 comments
Labels
✨ code quality Uncle Bob would be proud 🎓 student programmer Work, work...

Comments

@SSoelvsten
Copy link
Owner

SSoelvsten commented Feb 19, 2024

Since the request<...> class has to be a POD, we should add make_request functions that

  • make_request<...>(): Default initialise all values, e.g. the node carry with nil
  • make_request<1, ...>(request<0>) Copy over all values and set the node carry to nil
  • make_request<2, ...>(request<0>) Copy over all values and set the node carry to nil. Similarly for the argument having only one node carry.

And similarly make_request_data. Of course, they should be unit tested. Then, they can be used used in:

  • bdd/if_then_else.cpp
  • internal/algorithms/prod2.h
  • internal/algorithms/quantify.h
@SSoelvsten SSoelvsten added ✨ code quality Uncle Bob would be proud 🎓 student programmer Work, work... labels Feb 19, 2024
@SSoelvsten SSoelvsten added this to the v2.0 : API Revamp milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ code quality Uncle Bob would be proud 🎓 student programmer Work, work...
Projects
None yet
Development

No branches or pull requests

1 participant