Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build as a Shared Library #200

Open
SSoelvsten opened this issue Dec 18, 2021 · 1 comment
Open

Build as a Shared Library #200

SSoelvsten opened this issue Dec 18, 2021 · 1 comment
Labels
📁 build CMake, GitHub Actions etc. ✨ feature New operation or other feature help wanted Extra attention is needed

Comments

@SSoelvsten
Copy link
Owner

SSoelvsten commented Dec 18, 2021

It is not possible to build Adiar as a shared library. Some user's would like to build Adiar once and then install it. This way, you do not need to include it as a submodule to each of your projects (and build it for each of them independently). Furthemore, allowing this would make Adiar usable in closed-source projects (by circumventing TPIE's LGPL v3).

Note:
This should then also be made to work with CMake's find_package.

Note:
People may depend on multiple versions of Adiar. Hence, one should install it with the version number suffixed. Look here for how to do so.

@SSoelvsten SSoelvsten added 🔥 bug Something isn't working help wanted Extra attention is needed 📁 build CMake, GitHub Actions etc. labels Dec 18, 2021
@SSoelvsten SSoelvsten pinned this issue Dec 18, 2021
@SSoelvsten SSoelvsten added this to the Proprietary Usage milestone Dec 20, 2021
@SSoelvsten
Copy link
Owner Author

If the user at this point sets ADIAR_SHARED to ON then CMake will crash - there is no reason for it to cryptically fail and have tons of settings that are only related to building it as a shared library.

@SSoelvsten SSoelvsten changed the title Unable to build as a shared library Cannot be built as a Shared Library Oct 26, 2022
@SSoelvsten SSoelvsten changed the title Cannot be built as a Shared Library Build and Install as a Shared Library Sep 11, 2023
@SSoelvsten SSoelvsten added ✨ feature New operation or other feature and removed 🔥 bug Something isn't working labels Sep 11, 2023
@SSoelvsten SSoelvsten changed the title Build and Install as a Shared Library Build as a Shared Library Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 build CMake, GitHub Actions etc. ✨ feature New operation or other feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant