Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#26 feat TermsOfService View #32

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

mnbvcxzyj
Copy link
Member

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ์„œ๋น„์Šค ์ด์šฉ ์•ฝ๊ด€ ๋ทฐ ๊ตฌํ˜„ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๐ŸŒฑ PR ํฌ์ธํŠธ

  • ํšŒ์›๊ฐ€์ž… ํ”Œ๋กœ์šฐ๋ฅผ ์ „์ฒด์ ์œผ๋กœ SignUpFeature ์—์„œ ๊ด€๋ฆฌํ•˜๋ คํ•˜๋Š”๋ฐ ๋” ์ชผ๊ฐœ๋Š”๊ฒŒ ์ข‹์„ใ…ˆใ…ฃ.. ์ ์  ๋” ๋ณต์žกํ•ด์งˆ ๊ฑฐ ๊ฐ™์•„์„œ ๊ณ ๋ฏผ์ž…๋‹ˆ๋‹น

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

2025-01-16.1.50.26.mov

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@mnbvcxzyj mnbvcxzyj added ๐Ÿฆน๐Ÿปโ€โ™€๏ธ ์˜ˆ์ง€ ๐ŸŽจ style UI ๊ฐœ๋ฐœ ๋ฐ ์ฝ”๋“œ ๋ณ€๊ฒฝ labels Jan 15, 2025
@mnbvcxzyj mnbvcxzyj self-assigned this Jan 15, 2025
Copy link
Collaborator

@Sangwook123 Sangwook123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค ! ! ์ˆ˜์ •์‚ฌํ•ญ ๋ฐ˜์˜ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค ! !

Comment on lines 39 to 46
private func isNextStepEnabled() -> Bool {
switch signUpFeature.currentContent {
case .termsOfServiceView:
return signUpFeature.state.isAgree
default:
return true
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ฐฉ์‹ ๋„ˆ๋ฌด ์ข‹์€๊ฑฐ๊ฐ™์Šต๋‹ˆ๋‹ค. feature๋กœ ์˜ฎ๊ฒจ์„œ ์ƒํƒœ๋กœ ๊ด€๋ฆฌํ•˜๋Š”๊ฑฐ ์–ด๋– ๊นŒ์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค ๐Ÿ’ช๐Ÿป ๋„์™€์ฃผ์‹  ๋•๋ถ„์— ์ฝ”๋“œ ์ด์‚ฌ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค..


struct TermsOfServiceView: View {
@EnvironmentObject var signUpFeature: SignUpFeature
@State private var agreeStatus: [Bool] = [false, false, false]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‚˜์ค‘์— ํšŒ์›๊ฐ€์ž… API ์˜๋ฉด ์ด์ •๋ณด ํ•„์š”ํ•  ๊ฒƒ ๊ฐ™์€๋ฐ ์ด ์ •๋ณด๋„ signupfeature์—์„œ ๊ด€๋ฆฌํ•˜๋Š”๊ฒŒ ์ข‹์„๊ฒƒ๊ฐ™์Šด๋‹ˆ๋‹ค !

@mnbvcxzyj mnbvcxzyj requested a review from Sangwook123 January 16, 2025 02:58
@mnbvcxzyj mnbvcxzyj merged commit 2db4d5b into develop Jan 16, 2025
@Jang99u
Copy link

Jang99u commented Jan 16, 2025

์•„์š”์˜ ์‹  ๋“ฑ์žฅ..

@sayyyho
Copy link
Member

sayyyho commented Jan 16, 2025

์›น์„ ๋„˜์–ด ์•„์š”๋กœ..ใ„ทใ„ท

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐ŸŽจ style UI ๊ฐœ๋ฐœ ๋ฐ ์ฝ”๋“œ ๋ณ€๊ฒฝ ๐Ÿฆน๐Ÿปโ€โ™€๏ธ ์˜ˆ์ง€
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] ์ด์šฉ์•ฝ๊ด€ view ๊ตฌํ˜„
4 participants